BUG: can't round-trip non-nano Timestamp #51087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 31, 2023 15:29
mroeschke
added
the
Non-Nano
jbrockmendel
reviewed
Feb 1, 2023
jbrockmendel
reviewed
Feb 1, 2023
jbrockmendel
reviewed
Feb 1, 2023
jbrockmendel
reviewed
Feb 4, 2023
jbrockmendel
reviewed
Feb 8, 2023
jbrockmendel
reviewed
Feb 8, 2023
jbrockmendel
reviewed
Feb 8, 2023
jbrockmendel
reviewed
Feb 8, 2023
| elif reso == NPY_DATETIMEUNIT.NPY_FR_M: | ||
| # 2629746 comes from dividing the "Y" case by 12. | ||
| m = 1_000_000_000 * 2629746 | ||
| p = 9 | ||
| m = multiplier * 2629746 |
There was a problem hiding this comment.
I'm pretty sure the M and Y cases in precision_from_unit are no longer reached, in which case the entire m part of this function i think can be replaced with get_conversion_factor (OK to consider out of scope)
added 2 commits
February 8, 2023 16:07
This reverts commit 27fd951.
jbrockmendel
reviewed
Feb 9, 2023
pandas/_libs/tslibs/conversion.pyx
Outdated
| @@ -294,9 +296,15 @@ cdef _TSObject convert_to_tsobject(object ts, tzinfo tz, str unit, | |||
| if ts == NPY_NAT: | |||
| obj.value = NPY_NAT | |||
| else: | |||
| ts = cast_from_unit(ts, unit) | |||
| if unit is None: | |||
| in_reso = abbrev_to_npy_unit("ns") | |||
There was a problem hiding this comment.
should we assign unit="ns" here since we pass it to cast_from_unit below?
There was a problem hiding this comment.
yup, good one, thanks
jbrockmendel
approved these changes
Feb 9, 2023
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This should fix the interger case, but not the float one, so let's still keep the issue open for now